feat(corelib): Extend trait

[julio4]

• Define the Extend trait: Extend a collection with the contents of an iterator.
• Implement ArrayExtend

Examples

let mut arr = array![1_u32, 2, 3];
arr.extend((4..6_u32));
assert_eq!(arr, array![1, 2, 3, 4, 5]);

Known Issue

DIrectly calling into_iter in the argument cause panic.

let mut arr = array![1, 2];
arr.extend(array![3, 4, 5].into_iter()); // fails

[reviewable-StarkWare]

This change is 

[julio4]

@orizi for visibility

Reviewable status: 0 of 5 files reviewed, all discussions resolved

[orizi]

this now should work (if you rebase).
though - if IntoIterator is called from the outside it would probably not work for the time being (with a diagnostic).
but adding additional type info should work.

Reviewed 3 of 5 files at r3, all commit messages.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @julio4)

---

corelib/src/test/array_test.cairo line 251 at r3 (raw file):

    arr.extend((4..6_u32).into_iter());
    assert_eq!(arr, array![1, 2, 3, 4, 5]);
}

Suggestion:

#[test]
fn test_array_extend() {
    let mut arr = array![1_u32, 2, 3];
    arr.extend((4..6_u32).into_iter());
    assert_eq!(arr, array![1, 2, 3, 4, 5]);
}

[julio4]

I'm curious to know why calling IntoIterator from the outside is failing.
IntoIterator::into_iter() always return an Iterator, and all Iterators implement IntoIterator.
I'm not sure how to add additional type infos

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

corelib/src/test/array_test.cairo line 251 at r3 (raw file):

    arr.extend((4..6_u32).into_iter());
    assert_eq!(arr, array![1, 2, 3, 4, 5]);
}

Done.

[orizi]

Reviewed 1 of 5 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @julio4)

---

corelib/src/test/array_test.cairo line 249 at r4 (raw file):

fn test_array_extend() {
    let mut arr = array![1_u32, 2, 3];
    arr.extend((4..6_u32).into_iter());

Suggestion:

    arr.extend(4..6_u32);

---

corelib/src/test/array_test.cairo line 256 at r4 (raw file):

// fn test_array_extend_panic() {
//     let mut arr: Array<u32> = array![1, 2, 3];
//     arr.extend((4..6_u32).into_iter());

remove the commented test.

[orizi]

it has something to do with the fact that we have an impl::impl::something sort of usage - it causes some sort of an internal mix which is difficult to solve.

adding extra info would just work with an additional variable with a specific type before passing it as a param.

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @julio4)

[julio4]

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

corelib/src/test/array_test.cairo line 256 at r4 (raw file):

Previously, orizi wrote…

remove the commented test.

Done.

---

corelib/src/test/array_test.cairo line 249 at r4 (raw file):

fn test_array_extend() {
    let mut arr = array![1_u32, 2, 3];
    arr.extend((4..6_u32).into_iter());

Done.

[orizi]

Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @julio4)

---

corelib/src/test/array_test.cairo line 249 at r5 (raw file):

fn test_array_extend() {
    let mut arr = array![1_u32, 2, 3];
    arr.extend((4..6_u32));

Suggestion:

    arr.extend(4..6_u32);

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @julio4)

---

a discussion (no related file):
@gilbens-starkware for 2nd eye