-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lean verification code generator #7180
Draft
yoavseginer
wants to merge
50
commits into
starkware-libs:main
Choose a base branch
from
yoavseginer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that some checks fail, something about a mismatch between the command number and crate number. I indeed added a new crate, so I probably should have added something additional somewhere, but I don't know where. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a libfunc test is run and the Lean generator is turned on, Lean code is generated which can be used to verify the correctness (soundness and completeness) of the libfunc. The Lean code is generated into files in a separate verification directory.
All code for the Lean generator is behind the 'lean' compilation feature. Moreover, having compiled the cairo compiler with the 'lean' feature, one must also set the CAIRO_GEN_LEAN environment flag to generate the Lean code (this may be redundant and can easily be removed).
The Lean generator code has two main components: one (mainly inside the Casm builder) collects auxiliary information during the build process, which is later needed by the Lean generator. The generation of the Lean code then takes place after the test was completed, and is implemented in a separate crate. Some small changes had to be introduced to the compiler and test code to allow the auxiliary information collected in the builder to reach the Lean generator.
Finally, a few libfunc tests were added (in u256 and u512). The tests modify existing tests by not destroying the U128MulGuarantees returned by the core libfunc. In this way the Lean proof only verifies the core functionality.