Cache deref chain

[ilyalesokhin-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-semantic/src/resolve/mod.rs line 120 at r1 (raw file):

    /// A map from member names to their semantic representation and the number of deref operations
    /// needed to access them.
    pub members: OrderedHashMap<SmolStr, (Member, usize)>,

not sure if this should be move to the deref_chain query result.

Code quote:

   pub members: OrderedHashMap<SmolStr, (Member, usize)>,

[orizi]

Reviewed 3 of 5 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 4 of 5 files reviewed, 6 unresolved discussions (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

---

crates/cairo-lang-semantic/src/items/imp.rs line 772 at r2 (raw file):

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct DerefChain {

doc

---

crates/cairo-lang-semantic/src/items/imp.rs line 777 at r2 (raw file):

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct DerefInfo {

doc

---

crates/cairo-lang-semantic/src/items/imp.rs line 783 at r2 (raw file):

}

pub fn deref_chain_cycle(

give a pointer back to the query as a doc.

---

crates/cairo-lang-semantic/src/items/imp.rs line 793 at r2 (raw file):

}

pub fn deref_chain(db: &dyn SemanticGroup, ty: TypeId, try_deref_mut: bool) -> Maybe<DerefChain> {

give a pointer back to the query as a doc.

---

crates/cairo-lang-semantic/src/items/imp.rs line 820 at r2 (raw file):

}

pub fn get_deref_func_and_target(

doc and remove pub

[ilyalesokhin-starkware]

Reviewable status: 2 of 5 files reviewed, 6 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/items/imp.rs line 772 at r2 (raw file):

Previously, orizi wrote…

doc

Done.

---

crates/cairo-lang-semantic/src/items/imp.rs line 777 at r2 (raw file):

Previously, orizi wrote…

doc

Done.

---

crates/cairo-lang-semantic/src/items/imp.rs line 783 at r2 (raw file):

Previously, orizi wrote…

give a pointer back to the query as a doc.

Done.

---

crates/cairo-lang-semantic/src/items/imp.rs line 793 at r2 (raw file):

Previously, orizi wrote…

give a pointer back to the query as a doc.

Done.

[orizi]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

---

crates/cairo-lang-semantic/src/items/imp.rs line 780 at r3 (raw file):

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct DerefInfo {
    /// deref function

Suggestion:

    /// The concrete `Deref::deref` function

[ilyalesokhin-starkware]

Reviewable status: 3 of 6 files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/items/imp.rs line 820 at r2 (raw file):

Previously, orizi wrote…

doc and remove pub

Done.

---

crates/cairo-lang-semantic/src/items/imp.rs line 780 at r3 (raw file):

#[derive(Clone, Debug, Eq, PartialEq)]
pub struct DerefInfo {
    /// deref function

Done.

[orizi]

Reviewed 2 of 3 files at r4, 2 of 2 files at r5.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)

---

before.after line 0 at r5 (raw file):
what us this file?

[ilyalesokhin-starkware]

Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)

---

before.after line at r5 (raw file):

Previously, orizi wrote…

what us this file?

Done.

[orizi]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)