-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hash.cairo #7225
base: main
Are you sure you want to change the base?
Update hash.cairo #7225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sentdeed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sentdeed)
corelib/src/hash.cairo
line 7 at r1 (raw file):
//! functions. //! //! The simplest way to make a type hashable is to use `#[derive(Hash)]`. Hashing a value is done by
run ./scripts/cairo_fmt.sh
.
@orizi I ran |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please view and answer at https://reviewable.io/reviews/starkware-libs/cairo/7225#-
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @sentdeed)
corelib/src/hash.cairo
line 7 at r1 (raw file):
Previously, orizi wrote…
run
./scripts/cairo_fmt.sh
.
you haven't properly fixed it - as the CI still fails.
please note the other comment for the actual formatting result.
corelib/src/hash.cairo
line 8 at r2 (raw file):
//! The simplest way to make a type hashable is to use `#[derive(Hash)]`. Hashing a value is done by //! initializing a `HashState` corresponding to a hash function, updating it with the value, and then //! finalizing it to get the hash result.
Suggestion:
//! This module provides a hash state abstraction that can be updated with values and finalized to
//! produce a hash. This allows for flexible and efficient hashing of any type with different hash
//! functions.
//!
//! The simplest way to make a type hashable is to use `#[derive(Hash)]`. Hashing a value is done by
//! initializing a `HashState` corresponding to a hash function, updating it with the value, and
//! then finalizing it to get the hash result.
@orizi done ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @sentdeed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sentdeed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sentdeed)
a discussion (no related file):
still broken.
please run ./scripts/cairo_fmt.sh
locally and push.
if you won't - please close PR.
initiating
initializing
FIX