Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hash.cairo #7225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update hash.cairo #7225

wants to merge 3 commits into from

Conversation

sentdeed
Copy link

@sentdeed sentdeed commented Feb 5, 2025

initiating
initializing

FIX

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sentdeed)

@orizi orizi enabled auto-merge February 5, 2025 15:14
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sentdeed)


corelib/src/hash.cairo line 7 at r1 (raw file):

//! functions.
//!
//! The simplest way to make a type hashable is to use `#[derive(Hash)]`. Hashing a value is done by

run ./scripts/cairo_fmt.sh.

@sentdeed
Copy link
Author

sentdeed commented Feb 6, 2025

@orizi I ran ./scripts/cairo_fmt.sh , and no changes were needed. Let me know if anything else is required.

auto-merge was automatically disabled February 6, 2025 09:22

Head branch was pushed to by a user without write access

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please view and answer at https://reviewable.io/reviews/starkware-libs/cairo/7225#-

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @sentdeed)


corelib/src/hash.cairo line 7 at r1 (raw file):

Previously, orizi wrote…

run ./scripts/cairo_fmt.sh.

you haven't properly fixed it - as the CI still fails.

please note the other comment for the actual formatting result.


corelib/src/hash.cairo line 8 at r2 (raw file):

//! The simplest way to make a type hashable is to use `#[derive(Hash)]`. Hashing a value is done by
//! initializing a `HashState` corresponding to a hash function, updating it with the value, and then
//! finalizing it to get the hash result.

Suggestion:

//! This module provides a hash state abstraction that can be updated with values and finalized to
//! produce a hash. This allows for flexible and efficient hashing of any type with different hash
//! functions.
//!
//! The simplest way to make a type hashable is to use `#[derive(Hash)]`. Hashing a value is done by
//! initializing a `HashState` corresponding to a hash function, updating it with the value, and
//! then finalizing it to get the hash result.

@sentdeed
Copy link
Author

sentdeed commented Feb 6, 2025

@orizi done !

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @sentdeed)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sentdeed)

@orizi orizi enabled auto-merge February 6, 2025 09:37
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sentdeed)


a discussion (no related file):
still broken.

please run ./scripts/cairo_fmt.sh locally and push.

if you won't - please close PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants