fix(docs): correct s component range in eth_signature documentation #9508
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect documentation for
scomponent range validation inverify_eth_signatureandis_eth_signature_validfunctions.Type of change
Why is this change needed?
The documentation stated that both
randscomponents are validated in range[1, N), but the actual code validatessin the stricter range[1, N/2](viais_signature_s_valid). This is an important distinction for signature malleability protection (EIP-2).What was the behavior or documentation before?
Documentation incorrectly stated:
What is the behavior or documentation after?
Documentation now correctly states: