Add refunds #75
Merged
Add refunds #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerzhner
force-pushed
the
refund
branch
3 times, most recently
from
8d55c1f to
13643ae
Compare
At the moment, L2 contract is not concerned with WHY a batch has been withdrawn
A batch can be created to: - Authorize tickets - Refund tickets
andrewgordstewart
approved these changes
Dec 16, 2021
contracts/l2.sol
Outdated
| @@ -189,4 +189,25 @@ contract L2 is SignatureChecker { | |||
|
|
|||
| batches[honestStartNonce].status = BatchStatus.Refunded; | |||
| } | |||
|
|
|||
| function refund(uint256 index) public { | |||
There was a problem hiding this comment.
To make sure I understand refund, it:
- accepts the
indexof the ticket we want to refund - refunds all tickets whose nonce is
<= indexthat have not yet been authorized
?
If so, it probably deserves some documentation to that effect. (And we should put a short statement in the spec.)
contracts/l2.sol
Outdated
|
|
||
| function refund(uint256 index) public { | ||
| require( | ||
| block.timestamp > tickets[index].timestamp + maxAuthDelay, |
There was a problem hiding this comment.
nit: this logic makes me think that tickets[index].timestamp would be more clear if it was renamed to tickets[index].createdAt.
There was a problem hiding this comment.
I like it: 1b63880
Also add documentation for the refund function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer can refund a ticket after the authorization window expires. When refund is called for a ticket:
This PR also reduces
BatchStatusto 2 types: Authorized and Withdrawn.Fixes #74