This repository was archived by the owner on Nov 8, 2023. It is now read-only.
Use bigint exclusively to represent balances.
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
commented
Oct 19, 2023
| Number(this.getOwnerBalance()) < BigInt(amount) | ||
| (await this.getOwnerBalance()) < amount |
There was a problem hiding this comment.
Here we were actually casting a promise to a number, which results in nan < amount which is always false. So this check was completely broken.
There was a problem hiding this comment.
Yowsa. Good catch.
Because we're good wallet developers, I think there's at least a 60% chance that the intermediary would reject HTLCs that should have failed here.
NiloCK
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126