Skip to content

Improve ts-rpc-test config #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improve ts-rpc-test config #1804

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b499b0
run test on pushes to main branch
geoknee Oct 4, 2023
2342607
tweak documentation
geoknee Oct 4, 2023
0b3c8a0
improve docs
geoknee Oct 4, 2023
b01563b
try using node 16
geoknee Oct 4, 2023
27aeaa5
try node v20
geoknee Oct 4, 2023
fbdcc92
update node version across all GHAs
geoknee Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ts-rpc-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: TypeScript RPC Client Test

on:
push:
branches: [main]
pull_request:
workflow_dispatch:
jobs:
Expand All @@ -14,7 +16,7 @@ jobs:
- uses: actions/setup-node@v3
with:
cache: "yarn"
node-version: "18.15.0"
node-version: "20.0.0"
Copy link
Contributor

@lalexgap lalexgap Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make this change across all our github workflows, to keep things consistent?

Copy link
Contributor Author

@geoknee geoknee Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep fbdcc92


# Install foundry so we can use it to run a chain instance
- name: Install Foundry
Expand Down
4 changes: 2 additions & 2 deletions packages/nitro-rpc-client/scripts/client-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ function getChannelIdFromObjectiveId(objectiveId: string): string {
return objectiveId.split("-")[1];
}

// Waits for the RPC server to be available by sending a simple get_address POST request until we get a response
// Waits up to waitDuration milliseconds for the RPC server to be available
async function waitForRPCServer(
port: number,
waitDuration: number
Expand All @@ -317,7 +317,7 @@ async function waitForRPCServer(
);
}

// Checks if the server is up by sending a simple get_address POST request
// Checks if the server is up by sending a simple GET request to the health endpoint
// This is specific to the HTTP/WS RPC transport
async function isServerUp(port: number): Promise<boolean> {
let result: AxiosResponse<unknown, unknown>;
Expand Down