Skip to content

Rebase Fulu onto unstable #7070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 270 commits into from
Apr 24, 2025
Merged

Rebase Fulu onto unstable #7070

merged 270 commits into from
Apr 24, 2025

Conversation

Tomi-3-0
Copy link
Contributor

No description provided.

jangko and others added 30 commits April 13, 2025 17:35
…6727)

* Bump nim-web3 to c8f36f59cb354196cfe117b6866e81d450c8cfd7
* no need to convert accessList and authorizationList anymore
Add test runner for future tests / ensure it gets compiled.
* add getMetaDataV3

* simpler fix, to review

* drop returns
* update Docker images to stable/Bookworm

* add copyright headers
- Bump sqlite-amalgamation to `3.47.1`
- chore: use supported selector operators
- Attempt to fix broken autobahn CI artifact uploading
…#6742)

- discv4: Fix assert on invalid RLP list in Neighbours message
…m#6746)

- Add newPayload template for engine_newPayloadV4 and
  restore eth_getBlockReceipts callsig
…tatus-im#6749)

- Bump libbacktrace to `1db85642e3fca189cf4e076f840a45d6934b2456`
Add `Compounding on` text to Electra fork transition art.

Co-authored-by: Beatscribe <[email protected]>
To avoid having to wait several minutes for LC finality gossip, obtain
extra finality update once LC sync finishes.
* Support reading `bootstrap_nodes.yaml`

`bootstrap_nodes.txt` is retired in lieu of `bootstrap_nodes.yaml`,
start reading `.yaml` format (similar to `.enr`).

* Support Gnosis Chiado format (duplicates of entries in other file)
* taskpools: bump

* better raises effects
* get rid of custom naming

* bump

* oops

* bump stable
* rewrite: response checking from RequestManager for blobs

* clean whitespace

* use a comparator and std instead

* sort incoming blobs by index

* fix list traversal

---------

Co-authored-by: tersec <[email protected]>
…#6759)

* wait for fulu fork epoch to pass, then trigger metadata_v3

* tiny fix
)

* add csc to enr and metadata

* add column filtering into RequestManager

* nits

* add comment

* resolved reviews 1

* added local custody column set into RequestManager as a field

* faster lookups with hashsets

* fix regressions, fix other reviews, fix response checking for columns

* simpler fix for hashsets
cheatfate and others added 24 commits April 13, 2025 17:35
* Add custom filters for PeerPool.

* Update AllTests.

* Eliminate unneeded constructions.

* Address review comments.
Fix clear() does not properly cleanup empties[] array.

* Attempt to fix crash but still use binary search instead of linear.

* Make iterators safe in async environment.

* Add comments about iterators usage.

* Address review comments.

* Fix number of PeerPool crashes.
Switch back to distinct PeerIndex type to get ability to use custom cmp function.
Switch back to linear search because binarySearch could not be working correctly.
Make tests work with `ref Peer` instead of `Peer`, which helps reveal crashes.

* Eliminate debugging symbols.

* Address review comments.
…pool (status-im#7043)

* fix checking for existing covering Electra aggregates in attestation pool

* fix gossip validation usage of Electra covers
…#7045)

* Disable strict requirement for `eth-consensus-version` header for Deneb fork.

* Making it working with weird specification requirements, with `eth-consensus-version` is not required for JSON responses.

* Address review comments.
* added custody group count in node/identity endpoint

* fix copyright year
* added chain aggregates cache tests

* in order to pack electra chained attestations, nimbus scores and
aggregates in an ordered fashion to ease the packing of these
attestations.

However, after the scored and aggregate, a nimbus table (not ordered)
was being used, and such, not producing optimal chain aggregates.

Solution arise from the use of an ordered table.

* review fixes

---------

Co-authored-by: pmmiranda <[email protected]>
* feat: add BlockGossipObject for sse event

* feat: enable block_gossip topic

* feat: create async queue and emit event

* chore: copyright year

* fix: check before onAdded exists and remove decodeString
* add MsgSource as el too

* lint
* add: compute_cells for getBlobsV2

* updated link
* reduce light client data store stack usage

* copyright year linting
@Tomi-3-0 Tomi-3-0 closed this Apr 13, 2025
@Tomi-3-0 Tomi-3-0 reopened this Apr 13, 2025
@tersec
Copy link
Contributor

tersec commented Apr 16, 2025

https://github.com/status-im/nimbus-eth2/actions/runs/14431836966/job/40692379801?pr=7070

The following files do not have an up-to-date copyright year:
- beacon_chain/beacon_chain_db.nim
- beacon_chain/consensus_object_pools/data_column_quarantine.nim
- beacon_chain/consensus_object_pools/sync_committee_msg_pool.nim
- beacon_chain/fork_choice/proto_array.nim
- beacon_chain/gossip_processing/batch_validation.nim
- beacon_chain/gossip_processing/block_processor.nim
- beacon_chain/gossip_processing/optimistic_processor.nim
- beacon_chain/light_client.nim
- beacon_chain/networking/eth2_discovery.nim
- beacon_chain/nimbus_light_client.nim
- beacon_chain/spec/eth2_merkleization.nim
- beacon_chain/spec/peerdas_helpers
- beacon_chain/spec/presets/gnosis/electra_preset.nim
- beacon_chain/spec/presets/mainnet/electra_preset.nim
- beacon_chain/spec/presets/minimal/electra_preset.nim
- beacon_chain/validators/validator_duties.nim
- docker/dist/binaries/Dockerfile.bn.amd64
- docker/dist/binaries/Dockerfile.bn.arm
- docker/dist/binaries/Dockerfile.bn.arm64
- docker/dist/binaries/Dockerfile.vc.amd64
- docker/dist/binaries/Dockerfile.vc.arm
- docker/dist/binaries/Dockerfile.vc.arm64
- ncli/ncli_split_keystore.nim
- ncli/ncli_testnet.nim
- nfuzz/libnfuzz.nim
- scripts/signers/web3signer.sh
- tests/consensus_spec/consensus_spec_tests_preset.nim
- tests/consensus_spec/electra/test_fixture_ssz_consensus_objects.nim
- tests/consensus_spec/test_fixture_light_client_data_collection.nim
- tests/test_beacon_chain_db.nim
- tests/test_discovery.nim
- tests/test_gossip_transition.nim
- tests/testdbutil.nim
- tests/teststateutil.nim
- wasm/index_ncli.html

Copy link

github-actions bot commented Apr 17, 2025

Unit Test Results

       15 files  +         3    2 630 suites  +816   1h 19m 21s ⏱️ + 23m 50s
  6 372 tests +  1 135    5 870 ✔️ +     981  502 💤 +154  0 ±0 
44 281 runs  +15 184  43 603 ✔️ +14 958  678 💤 +226  0 ±0 

Results for commit b5bc14d. ± Comparison against base commit 44531ad.

♻️ This comment has been updated with latest results.

@tersec tersec merged commit f14f935 into status-im:fulu Apr 24, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.