bump nim-libp2p to v1.15.1 #7864
Open
+39
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
force-pushed
the
DHY
branch
15 times, most recently
from
b6641a8 to
674980e
Compare
arnetheduck
reviewed
Jan 28, 2026
arnetheduck
reviewed
Jan 28, 2026
config.nims
Outdated
| it.len > 0) | ||
| # https://github.com/vacp2p/nim-lsquic/blob/main/lsquic.nimble | ||
| for asmPath in asmFiles: | ||
| exec "nasm -f win64 " & quoteShell(basepath / asmPath) & " -o " & |
Member
There was a problem hiding this comment.
in lsquic, I think it should be possible to do the following:
- call nasm with
staticExec, preferably gated to be called only when the object file is missing - use
{.passl: "asmoutput.o".}for linking it
the aim would be to avoid the need for these customizations of the config.nims file.
Member
There was a problem hiding this comment.
we do something similar with rcc and resource compilations in qt: https://github.com/arnetheduck/ngui/blob/master/src/ngui.nim#L13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.