Skip to content

[RFC]: add math/base/special/atanf #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
gunjjoshi opened this issue Mar 25, 2024 · 4 comments · Fixed by #2054
Closed
3 tasks done

[RFC]: add math/base/special/atanf #2035

gunjjoshi opened this issue Mar 25, 2024 · 4 comments · Fixed by #2054

Comments

@gunjjoshi
Copy link
Member

gunjjoshi commented Mar 25, 2024 •
edited
Loading

Description

Description

This RFC proposes adding math/base/special/atanf, which would be a single precision implementation for math/base/special/atan.

float stdlib_base_atanf( const float x )

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@gunjjoshi
Copy link
Member Author

I would like to work on this.

@gunjjoshi
Copy link
Member Author

gunjjoshi commented Mar 25, 2024 •
edited
Loading

For this, we will need constants/float32/pi. I will be making a separate PR for that.

@gunjjoshi gunjjoshi mentioned this issue Mar 25, 2024
Merged
1 task
@gunjjoshi
Copy link
Member Author

#2042 must be merged for this.

kgryte pushed a commit that referenced this issue Mar 25, 2024
@gunjjoshi
feat: add constants/float32/pi
f48de9d 
PR-URL: 	#2042
Ref: #2035
Reviewed-by: Athan Reines <[email protected]>
@gunjjoshi gunjjoshi mentioned this issue Mar 26, 2024
Merged
1 task
@gunjjoshi
Copy link
Member Author

#2046 must also be merged for this.

kgryte pushed a commit that referenced this issue Mar 26, 2024
@gunjjoshi
feat: add constants/float32/fourth-pi
8994c14 
PR-URL: 	#2046
Ref: #2035
Reviewed-by: Athan Reines <[email protected]>
@gunjjoshi gunjjoshi mentioned this issue Mar 26, 2024
Merged
1 task
kgryte added a commit that referenced this issue Mar 27, 2024
@gunjjoshi @kgryte
feat: add math/base/special/atanf
f141a9b 
PR-URL: 	#2054
Closes: #2035
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add math/base/special/atanf
1 participant
@gunjjoshi