Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/fourth-pi #2046

Merged
merged 1 commit into from
Mar 26, 2024
Merged

feat: add constants/float32/fourth-pi #2046

merged 1 commit into from
Mar 26, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Mar 26, 2024

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@gunjjoshi
Copy link
Member Author

This PR is a pre-requisite for #2035.

@gunjjoshi
Copy link
Member Author

Test Coverage report:

Screenshot 2024-03-26 at 09 02 23

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Mar 26, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte merged commit 8994c14 into stdlib-js:develop Mar 26, 2024
7 checks passed
@gunjjoshi gunjjoshi deleted the float32-pi04 branch March 26, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants