Skip to content
/ stdlib Public

[RFC]: add math/base/special/rad2degf #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
gunjjoshi opened this issue Apr 5, 2024 · 2 comments · Fixed by #2127
Closed
3 tasks done

[RFC]: add math/base/special/rad2degf #2124

gunjjoshi opened this issue Apr 5, 2024 · 2 comments · Fixed by #2127
Assignees
@gunjjoshi
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@gunjjoshi
Copy link
Member

gunjjoshi commented Apr 5, 2024 •
edited
Loading

Description

This RFC proposes adding math/base/special/rad2degf, which would be the the single-precision equivalent for math/base/special/rad2deg.

float stdlib_base_rad2degf( const float x )

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@gunjjoshi
Copy link
Member Author

I'd like to work on this.

@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Apr 5, 2024
@gunjjoshi gunjjoshi mentioned this issue Apr 5, 2024
Merged
1 task
@gunjjoshi
Copy link
Member Author

gunjjoshi commented Apr 5, 2024 •
edited
Loading

#2126 would be a pre-requisite for this one. While it isn't directly useful from the implementation point of view, it is required for benchmarks and examples.

kgryte pushed a commit that referenced this issue Apr 5, 2024
@gunjjoshi
feat: add constants/float32/two-pi
Loading
Loading status checks…
607aad5 
PR-URL: 	#2126
Ref: #2124
Reviewed-by: Athan Reines <kgryte@gmail.com>
@gunjjoshi gunjjoshi mentioned this issue Apr 5, 2024
Merged
1 task
kgryte added a commit that referenced this issue Apr 5, 2024
@gunjjoshi @kgryte
feat: add math/base/special/rad2degf
Loading
Loading status checks…
d774fe6 
PR-URL: 	#2127
Closes: #2124
Reviewed-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gunjjoshi gunjjoshi

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add math/base/special/rad2degf
2 participants
@kgryte @gunjjoshi