Skip to content

[RFC]: Add C implementation for @stdlib/math/base/special/acsch #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Pranavchiku opened this issue Feb 8, 2023 · 8 comments · Fixed by #1833
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/acsch #860

Pranavchiku opened this issue Feb 8, 2023 · 8 comments · Fixed by #1833
Assignees
@yaswanthkosuru
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Pranavchiku commented Feb 8, 2023 •
edited
Loading

Description

This RFC proposes adding native C implementation for stdlib/math/base/special/acsch.

double stdlib_base_acsch( const double x );

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added Enhancement Issue or pull request for enhancing existing functionality. RFC Request for comments. Feature requests and proposed changes. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Good First Issue A good first issue for new contributors! labels Feb 8, 2023
@Pranavchiku Pranavchiku changed the title [RFC]: Add native C implementation for stdlib/math/base/special/acsch [RFC]: Add native C implementation for @stdlib/math/base/special/acsch Feb 8, 2023
@Pranavchiku Pranavchiku changed the title [RFC]: Add native C implementation for @stdlib/math/base/special/acsch [RFC]: Add C implementation for @stdlib/math/base/special/acsch Feb 8, 2023
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. and removed Enhancement Issue or pull request for enhancing existing functionality. labels Feb 23, 2024
@raunak-dev-edu
Copy link
Contributor

Hey @Pranavchiku @kgryte , I would like to work on this issue but let me know how this is different from issue #861 ( asec) and #859 (acsc). What's make different to each of these three functions

@kgryte
Copy link
Member

kgryte commented Feb 25, 2024

@raunak-dev-edu They are different functions, as may be observed by examining the JS implementations of the various packages. Each of the linked issues achieves something similar; however, the implementations will be different.

@yaswanthkosuru
Copy link
Contributor

yaswanthkosuru commented Feb 26, 2024 •
edited
Loading

hi @kgryte @Pranavchiku @rotu To solve these i want to add all files inside @stdlib/math/base/special/acsch
update readme.md
include.gypi
binding.gyp
include/stdlib/math/base/special/
src
manifest.json
lib
examples
benchmark
test)(similar to #769) and implement acsch functionality.
did my understand up to now is correct. Did i continue to implement same as said.

@Pranavchiku
Copy link
Member Author

Yes, please feel free to open a draft PR.

@yaswanthkosuru yaswanthkosuru mentioned this issue Mar 3, 2024
Closed
@Snehil-Shah
Copy link
Member

@yaswanthkosuru are you still working on this? If not, can I take this up?

@yaswanthkosuru
Copy link
Contributor

yaswanthkosuru commented Mar 7, 2024 •
edited
Loading

@yaswanthkosuru are you still working on this? If not, can I take this up?
yesterday unfortunately my system crashed so I close pr
I still working. i lost git file but i backup saved code .so i create new ubuntu system .i reopen new pr within 1 day

@Rejoan-Sardar
Copy link
Contributor

@yaswanthkosuru are you still working on this? If not, can I take this up?

@Snehil-Shah
Copy link
Member

@yaswanthkosuru are you still working on this? If not, can I take this up?

I am working on it.

This was referenced Mar 11, 2024
Closed
Merged
kgryte added a commit that referenced this issue Mar 11, 2024
@Snehil-Shah @kgryte
feat: add C implementation for math/base/special/acsch
6e31e73 
Closes: #860
PR-URL: 	#1833
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Snehil Shah <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaswanthkosuru yaswanthkosuru

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
6 participants
@kgryte @Pranavchiku @raunak-dev-edu @yaswanthkosuru @Rejoan-Sardar @Snehil-Shah