feat: add C implementation for math/base/special/acsch
#1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Mar 3, 2024
Pranavchiku
suggested changes
Mar 3, 2024
Comment on lines
+117
to
+118
| double out = stdlib_base_acsch( 2.0 ); | ||
| // returns ~0.5493 |
There was a problem hiding this comment.
Suggested change
| double out = stdlib_base_acsch( 2.0 ); | |
| // returns ~0.5493 | |
| double out = stdlib_base_acsch( 1.0 ); | |
| // returns ~0.881 |
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2022 The Stdlib Authors. |
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2022 The Stdlib Authors. | |
| * Copyright (c) 2024 The Stdlib Authors. |
| #/ | ||
| # @license Apache-2.0 | ||
| # | ||
| # Copyright (c) 2018 The Stdlib Authors. |
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2018 The Stdlib Authors. | |
| # Copyright (c) 2024 The Stdlib Authors. |
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2018 The Stdlib Authors. |
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2018 The Stdlib Authors. | |
| * Copyright (c) 2024 The Stdlib Authors. |
|
|
||
| t = tic(); | ||
| for ( i = 0; i < ITERATIONS; i++ ) { | ||
| x = ( 100.0*rand_double() ) + 1.1; |
There was a problem hiding this comment.
Any specific reason for 1.1 ?
There was a problem hiding this comment.
ok thank u for pointing in right direction it should be x = ( 200.0*rand_double() ) -100(referenced from benchmark.js in same file)
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2022 The Stdlib Authors. |
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2022 The Stdlib Authors. | |
| * Copyright (c) 2024 The Stdlib Authors. |
| #/ | ||
| # @license Apache-2.0 | ||
| # | ||
| # Copyright (c) 2022 The Stdlib Authors. |
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2022 The Stdlib Authors. | |
| # Copyright (c) 2024 The Stdlib Authors. |
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2022 The Stdlib Authors. |
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2022 The Stdlib Authors. | |
| * Copyright (c) 2024 The Stdlib Authors. |
| /** | ||
| * @license Apache-2.0 | ||
| * | ||
| * Copyright (c) 2022 The Stdlib Authors. |
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2022 The Stdlib Authors. | |
| * Copyright (c) 2024 The Stdlib Authors. |
Comment on lines
+29
to
+30
| * out = stdlib_base_acsch( 2.0 ); | ||
| * // returns ~0.5493 |
There was a problem hiding this comment.
Suggested change
| * out = stdlib_base_acsch( 2.0 ); | |
| * // returns ~0.5493 | |
| * out = stdlib_base_acsch( 1.0 ); | |
| * // returns ~0.881 |
Pranavchiku
added
Feature
Planeshifter
changed the title
math/base/special/acsch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #860
Description
FEATURE TO
ADD C IMPLEMENTATION FOR ACSCH FUNCTION
This pull request:
@stdlib/math/base/special/acsch#860