feat: add C implementation for math/base/assert/is-nonnegative-integer#1746
feat: add C implementation for math/base/assert/is-nonnegative-integer#1746kgryte merged 6 commits intostdlib-js:developfrom gunjjoshi:is-nonnegative-integer
math/base/assert/is-nonnegative-integer#1746Conversation
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
stdlib/math/base/assert/is-nonnegative-integermath/base/assert/is-nonnegative-integer
kgryte
left a comment
There was a problem hiding this comment.
Thanks, @gunjjoshi. Left a couple of comments. Looks like we need to update math/base/napi/unary OR you can manually handle the add-on interface. See, e.g., https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/assert/is-even/src/addon.c.
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
For now, I've manually handled the add-on interface. |
|
Hey @kgryte @Planeshifter, any other suggestions on this ? |
Signed-off-by: Athan <kgryte@gmail.com>
Resolves #1723
Description
Added C implementation for
stdlib/math/base/assert/is-nonnegative-integer.This pull request:
stdlib/math/base/assert/is-nonnegative-integerRelated Issues
This pull request:
@stdlib/math/base/assert/is-nonnegative-integer#1723@stdlib/math/base/special/bernoulli#1664Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers