feat: add C implementation for math/base/special/gamma-lanczos-sum-expg-scaled
#1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
added
Needs Review
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
kgryte
added
Feature
kgryte
reviewed
Mar 11, 2024
| } else { | ||
| ax = x; | ||
| } | ||
| if ( ax <= 1.0 ) { |
There was a problem hiding this comment.
Same comment as in #1834 (comment)
There was a problem hiding this comment.
If the issue is L58, we should update evalrational-compile-c to handle infinities.
There was a problem hiding this comment.
Thanks for these suggestions. Once we are done with the PR for gamma-lanczos-sum, then I will make changes according to that here, so that things aren't repetitive.
Pranavchiku
added
Needs Changes
Closes: #860 PR-URL: #1833 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Snehil Shah <[email protected]> Signed-off-by: Athan Reines <[email protected]>
PR-URL: #1788 Closes: #41 --------- Signed-off-by: Sai Srikar Dumpeti <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1754 Closes: #1642 --------- Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1717 --------- Signed-off-by: Pranav <[email protected]> Signed-off-by: Athan Reines <[email protected]> Co-authored-by: Pranav <[email protected]> Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Pranav <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1774 Closes: #1637 --------- Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1837 Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1838 Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1841 Closes: #649 --------- Signed-off-by: GUNJ JOSHI <[email protected]> Signed-off-by: Pranav <[email protected]> Co-authored-by: Pranav <[email protected]> Reviewed-by: Pranav <[email protected]>
PR-URL: #1840 Closes: #1420 --------- Signed-off-by: Rejoan Sardar <[email protected]> Signed-off-by: Pranav <[email protected]> Co-authored-by: Pranav <[email protected]> Reviewed-by: Pranav <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1827 Closes: #1815 --------- Signed-off-by: Rutam <[email protected]> Signed-off-by: Pranav <[email protected]> Co-authored-by: Pranav <[email protected]> Reviewed-by: Pranav <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1786 Closes: #39 --------- Signed-off-by: Sai Srikar Dumpeti <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1785 Closes: #43 --------- Signed-off-by: Sai Srikar Dumpeti <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1789 Closes: #42 --------- Signed-off-by: Sai Srikar Dumpeti <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1787 Closes: #38 --------- Signed-off-by: Sai Srikar Dumpeti <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Co-authored-by: stdlib-bot <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1843 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: #1834 Closes: #1822 Ref: #649 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
…ventions PR-URL: #1864 Closes: #1516 Ref: #1152 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: #1972 Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1945 Closes: #1519 --------- Signed-off-by: Bryan Elee <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
…onventions PR-URL: #1929 Closes: #1520 --------- Signed-off-by: Pranav <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Pranav <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Pranav Goswami <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: #1974 Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
…ntions PR-URL: #1954 Closes: #1464 Ref: #1152 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
…nventions PR-URL: #1850 Closes: #1510 Ref: #1152 Co-authored-by: Athan Reines <[email protected]> Co-authored-by: Pranav Goswami <[email protected]> Reviewed-by: Athan Reines <[email protected]> Reviewed-by: Pranav Goswami <[email protected]> Signed-off-by: GUNJ JOSHI <[email protected]> Signed-off-by: Pranav Goswami <[email protected]> Signed-off-by: Athan Reines <[email protected]>
PR-URL: #1975 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
PR-URL: #1973 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
…ntions PR-URL: #1824 Closes: #1509 Ref: #1152 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
PR-URL: #1976 Ref: #1953 Reviewed-by: Athan Reines <[email protected]>
PR-URL: #1977 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
This reverts commit dbfeea7.
|
I will be opening a new pull request for this one, everything is getting mixed up here. Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1835
Description
This pull request:
math/base/special/gamma-lanczos-sum-expg-scaled.Related Issues
This pull request:
@stdlib/math/base/special/gamma-lanczos-sum-expg-scaled#1835Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers