Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/boxcox #1870

Merged
merged 12 commits into from
Mar 14, 2024
Merged

feat: add C implementation for math/base/special/boxcox #1870

merged 12 commits into from
Mar 14, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Mar 13, 2024 •
edited by kgryte
Loading

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_boxcox ( const double x, const double lambda )

Related Issues

Does this pull request have any related issues?

#649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. C Issue involves or relates to C. labels Mar 14, 2024
kgryte
kgryte approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @gunjjoshi! Thanks for working on this.

@kgryte kgryte removed Accepted RFC feature request which has been accepted. Needs Review A pull request which needs code review. labels Mar 14, 2024
@kgryte kgryte merged commit 63034fc into stdlib-js:develop Mar 14, 2024
7 checks passed
@gunjjoshi gunjjoshi deleted the boxcox branch March 18, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunjjoshi @kgryte