Skip to content

fix: variable type declarations in math/base/assert/int32-is-odd #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Planeshifter merged 1 commit into from
Mar 17, 2024
Merged

fix: variable type declarations in math/base/assert/int32-is-odd #1935

Planeshifter merged 1 commit into from
Mar 17, 2024

Conversation

@performant23
Copy link
Contributor

@performant23 performant23 commented Mar 17, 2024 •
edited
Loading

In some places, the type declarations are inconsistent according to the function prototype. This commit aims to fix those

Description

What is the purpose of this pull request?
Fix variable type declarations in the namespace

Related Issues

Does this pull request have any related issues?
N/A

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@performant23
fix: variable type declarations in math/base/assert/int32-is-odd
a02b4ac 
In some places, the type declarations are inconsistent according to the function prototype
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 17, 2024
@performant23
Copy link
Contributor Author

performant23 commented Mar 17, 2024

Hi, I was just checking out the packages where int32_t and uint32_t are used for my implementation fast/uint32-log2. So, just noticed there were some inconsistencies in the type declarations so thought to just open up a quick fix PR!

@Pranavchiku Pranavchiku added C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 17, 2024
Pranavchiku
Pranavchiku approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@Planeshifter Planeshifter merged commit fb6fb04 into stdlib-js:develop Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@performant23 @Pranavchiku @Planeshifter @stdlib-bot