Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/asinf #2030

Merged
merged 37 commits into from
Mar 25, 2024
Merged

feat: add math/base/special/asinf #2030

merged 37 commits into from
Mar 25, 2024

Conversation

gunjjoshi
Copy link
Member

Resolves #1944.

Description

What is the purpose of this pull request?

This pull request:

  • adds math/base/special/asinf, which computes the arcsine of a single precision floating point number.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Mar 25, 2024
@gunjjoshi
Update README.md
b533b82 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update repl.txt
a3c39da 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update README.md
d71a4ce 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update repl.txt
7c09de8 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update main.c
69cf9aa 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update main.c
e48d229 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi gunjjoshi mentioned this pull request Mar 25, 2024
Closed
1 task
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 25, 2024
kgryte
kgryte approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi! Will merge once CI passes.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 25, 2024
@gunjjoshi
Copy link
Member Author

LGTM. Thanks, @gunjjoshi! Will merge once CI passes.

Lot's of learnings from this one. Will keep all this in mind for future contributions, thanks for helping out !

@kgryte
Copy link
Member

kgryte commented Mar 25, 2024

@gunjjoshi Indeed. Trial by fire.

@kgryte kgryte merged commit 0038b4b into stdlib-js:develop Mar 25, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the asinf-2 branch March 25, 2024 09:57
@gunjjoshi gunjjoshi mentioned this pull request Apr 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add math/base/special/asinf
3 participants
@gunjjoshi @kgryte @stdlib-bot