Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/acscf #2111

Merged
merged 9 commits into from
Apr 3, 2024
Merged

feat: add math/base/special/acscf #2111

merged 9 commits into from
Apr 3, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 2, 2024

Resolves #2109.

Description

What is the purpose of this pull request?

This pull request:

float stdlib_base_acscf( const float x )

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Test coverage report:

Screenshot 2024-04-02 at 20 03 41

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 2, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Just a few small changes and should be ready for merge.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. labels Apr 2, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @gunjjoshi!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Apr 3, 2024
@kgryte kgryte merged commit bcf0e37 into stdlib-js:develop Apr 3, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the acscf branch April 3, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add math/base/special/acscf
3 participants