Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handle signed zeroes in math/base/special/atanf #2115

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: correctly handle signed zeroes in math/base/special/atanf #2115

merged 1 commit into from
Apr 3, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 3, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

  • modifies both C and JavaScript implementations to handle signed zeroes in math/base/special/atanf.
  • adds corresponding test for checking results with positive and negative zeroes.

These changes are based on this.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 3, 2024
@kgryte kgryte changed the title refactor: handling signed zeroes for math/base/special/atanf fix: correctly handle signed zeroes in math/base/special/atanf Apr 3, 2024
kgryte
kgryte approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte merged commit 4c5cc36 into stdlib-js:develop Apr 3, 2024
6 checks passed
@gunjjoshi gunjjoshi deleted the atanf branch April 4, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @kgryte @stdlib-bot