-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/asecf
#2120
Conversation
While working on this, I found that in Should I remove that too, in a quick patch ? |
@gunjjoshi Yes, go for it! Thanks! |
lib/node_modules/@stdlib/math/base/special/asecf/test/fixtures/julia/runner.jl
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/asecf/test/test.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gunjjoshi, for working on this. My main comment concerns test fixture generation. Once resolved, this should be good to merge.
@gunjjoshi Did the test fixtures remain the same? I am guessing yes since you did not add them in the commit. |
@kgryte Yes, they did remain the same. To re-check, I even deleted all the fixtures, re-generated them, still they didn't had any changes with the previous ones, and so they didn't come up in the commit. |
@gunjjoshi Thanks for the following up. In which case, I think this PR is good to go. |
PR-URL: #2123 Ref: #2120 (comment) Ref: #2120 (comment) Reviewed-by: Athan Reines <[email protected]>
Resolves #2118 .
Description
This pull request:
math/base/special/asecf
, which is the single-precision equivalent ofmath/base/special/asec
.Related Issues
This pull request:
math/base/special/asecf
#2118Questions
No.
Other
I've used the term
inverse (arc) secant
in the descriptions, followingmath/base/special/asec
.I haven't included
(in radians)
in the output descriptions, followingmath/base/special/asec
.Checklist
@stdlib-js/reviewers