Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: decrease tolerance and clean-up math/base/special/asind #2138

Merged
merged 2 commits into from
Apr 7, 2024
Merged

refactor: decrease tolerance and clean-up math/base/special/asind #2138

merged 2 commits into from
Apr 7, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 7, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

  • makes styling changes according to project conventions
  • decreases tolerance for tests

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 7, 2024
@gunjjoshi gunjjoshi changed the title refactor: decrease tolerance, make rectifications according to project conventions for math/base/special/asind refactor: decrease tolerance, make rectifications for math/base/special/asind Apr 7, 2024
kgryte
kgryte approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank, @gunjjoshi!

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Apr 7, 2024
@kgryte kgryte changed the title refactor: decrease tolerance, make rectifications for math/base/special/asind refactor: decrease tolerance and clean-up math/base/special/asind Apr 7, 2024
@kgryte kgryte merged commit 90177b2 into stdlib-js:develop Apr 7, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the asind branch April 7, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @kgryte @stdlib-bot