Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/acscdf #2148

Merged
merged 1 commit into from
Apr 14, 2024
Merged

feat: add math/base/special/acscdf #2148

merged 1 commit into from
Apr 14, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Apr 10, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

float stdlib_base_acscdf( const float x )

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Apr 10, 2024
@Planeshifter Planeshifter self-requested a review April 14, 2024 01:17
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Apr 14, 2024
Planeshifter
Planeshifter approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @gunjjoshi!

@Planeshifter Planeshifter merged commit 077a5e6 into stdlib-js:develop Apr 14, 2024
8 checks passed
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Apr 14, 2024
@gunjjoshi gunjjoshi deleted the acscdf branch April 14, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gunjjoshi @Planeshifter @kgryte @stdlib-bot