feat: add C implementation for math/base/special/lcm
#2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
approved these changes
May 29, 2024
kgryte
reviewed
Jun 2, 2024
| double bn; | ||
| double d; | ||
|
|
||
| if( a == 0.0 || b == 0.0 ) { |
kgryte
reviewed
Jun 2, 2024
Comment on lines
+45
to
+46
| } | ||
| else { |
kgryte
reviewed
Jun 2, 2024
Comment on lines
+51
to
+52
| } | ||
| else { |
kgryte
reviewed
Jun 2, 2024
| /** | ||
| * Computes the least common multiple (lcm). | ||
| * | ||
| * @private |
There was a problem hiding this comment.
This isn't a private API. The @private tag should be removed.
|
@gunjjoshi Would you mind submitting a small follow-up PR addressing the comments above? Thanks! |
1 task
Sure, I've made a PR #2296. |
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2276 Ref: stdlib-js#649 Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
math/base/special/lcm.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers