refactor: use signed integers for math/base/special/log10, as per FreeBSD
#2294
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kgryte
reviewed
Jun 2, 2024
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
kgryte
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
LGTM. Thanks, @gunjjoshi! I believe we'll need to do the same thing for log2, correct?
kgryte
reviewed
Jun 2, 2024
kgryte
reviewed
Jun 2, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Jun 2, 2024
Correct. I'll do that in a follow up PR. |
1 task
kgryte
pushed a commit
that referenced
this pull request
Jun 2, 2024
PR-URL: #2295 Ref: #2294 (review) Reviewed-by: Athan Reines <kgryte@gmail.com>
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2294 Ref: stdlib-js#2215 (comment) Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com> Signed-off-by: Athan Reines <kgryte@gmail.com>
aman-095
pushed a commit
to aman-095/stdlib
that referenced
this pull request
Jun 13, 2024
PR-URL: stdlib-js#2295 Ref: stdlib-js#2294 (review) Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
math/base/special/log10, as per itsFreeBSDimplementation..math/base/special/log10to follow FreeBSD version12.2.0#2215 (comment).Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers