-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add iter/cuany
#2440
feat: add iter/cuany
#2440
Conversation
Signed-off-by: Ridam Garg <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Ridam Garg <[email protected]>
Signed-off-by: Ridam Garg <[email protected]>
Signed-off-by: Ridam Garg <[email protected]>
Signed-off-by: Ridam Garg <[email protected]>
Signed-off-by: Ridam Garg <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Ridam Garg <[email protected]>
Signed-off-by: Ridam Garg <[email protected]>
Signed-off-by: Ridam Garg <[email protected]>
@RidamGarg Would you mind updating your OP to use our PR template? You should have been prompted to use that template when opening the PR. That template includes a checkbox that you need to check in order to allow your contributions to be included in the project. Also, it looks like CI is failing for your PR, so you'll want to address the lint and other errors before we perform a review. Thanks! |
Also, you're attempting to open a PR from your |
Hello @kgryte , Thanks for pointing out the problems. Can I get The PR template as I am not able to find it now. For linting errors, I am able to solve them for all the other files. But not able to solve it for Readme.md file & repl.txt. Can you help me with that? |
PR template can be found here: https://github.com/stdlib-js/stdlib/blob/develop/.github/PULL_REQUEST_TEMPLATE.md |
For an example, see other PRs. E.g., #2443. |
Done @kgryte |
@RidamGarg It looks like you did not follow the suggestions left in #2358 (review). For all future PRs, you need to follow our branching guidance. Any future PRs which don't won't be reviewed or accepted, as failure to follow that guidance results in significantly more work for reviewers. For this PR, I had to refactor the entirety of the implementation. Your prior approach simply consumed the entire source iterator, created a temporary array, and then returned a new iterator. You should ask, however, what happens if the source iterator has an infinite number of values? Additionally, you'll want to adhere more closely to our conventions: style, language (e.g., descriptions), and prior art. We place a high value on consistency. I've tested things locally, so I'll go ahead and merge. But any future PRs in which CI does not pass due to branching issues or lint errors will not be accepted. |
Okay @kgryte, I'll keep this in mind in the future. Sorry for the inconvenience caused. |
Description
This pull request:
adds the implementation of @stdlib/iter/cuany
Related Issues
This pull request:
@stdlib/iter/cuany
#2331Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers