Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/beta #2512

Merged
merged 4 commits into from
Jul 7, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 5, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_beta( const double a, const double b );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

We might not get 100% code coverage here, due to some lines of code being impossible to reach, such as the condition x === 0.0 in the evalrational function.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 5, 2024
@kgryte
Copy link
Member

kgryte commented Jul 5, 2024

@gunjjoshi Just checking. Did you compare to the latest Boost implementation? The source in main.c says v1.64, but I believe Boost has released new versions since then and it would be good to ensure we have the latest source.

@gunjjoshi
Copy link
Member Author

@kgryte I looked over the latest Boost implementation, i.e., v1.85. After comparing both v1.85 and v1.64, it seems that there is no difference in their implementations. Shall I just update the version in main.c then?

@kgryte
Copy link
Member

kgryte commented Jul 6, 2024

Yes, you can update the version in both the JavaScript and C implementation.

@Planeshifter Planeshifter self-requested a review July 7, 2024 15:06
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, thanks @gunjjoshi!

@Planeshifter Planeshifter merged commit d4fd701 into stdlib-js:develop Jul 7, 2024
8 checks passed
@gunjjoshi gunjjoshi deleted the beta branch August 21, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants