Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use stdlib equivalent of pow in math/base/special/roundn #2539

Merged
merged 1 commit into from
Jul 9, 2024
Merged

refactor: use stdlib equivalent of pow in math/base/special/roundn #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions lib/node_modules/@stdlib/math/base/special/roundn/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
{
"task": "build",
"src": [
"./src/roundn.c"
"./src/main.c"
],
"include": [
"./include"
Expand All @@ -41,17 +41,19 @@
"@stdlib/math/base/napi/binary",
"@stdlib/math/base/special/abs",
"@stdlib/math/base/special/round",
"@stdlib/math/base/special/pow",
"@stdlib/constants/float64/max-safe-integer",
"@stdlib/constants/float64/max-base10-exponent",
"@stdlib/constants/float64/min-base10-exponent",
"@stdlib/constants/float64/min-base10-exponent-subnormal",
"@stdlib/math/base/assert/is-infinite"
"@stdlib/math/base/assert/is-infinite",
"@stdlib/math/base/assert/is-nan"
]
},
{
"task": "benchmark",
"src": [
"./src/roundn.c"
"./src/main.c"
],
"include": [
"./include"
Expand All @@ -63,17 +65,19 @@
"dependencies": [
"@stdlib/math/base/special/abs",
"@stdlib/math/base/special/round",
"@stdlib/math/base/special/pow",
"@stdlib/constants/float64/max-safe-integer",
"@stdlib/constants/float64/max-base10-exponent",
"@stdlib/constants/float64/min-base10-exponent",
"@stdlib/constants/float64/min-base10-exponent-subnormal",
"@stdlib/math/base/assert/is-infinite"
"@stdlib/math/base/assert/is-infinite",
"@stdlib/math/base/assert/is-nan"
]
},
{
"task": "examples",
"src": [
"./src/roundn.c"
"./src/main.c"
],
"include": [
"./include"
Expand All @@ -85,11 +89,13 @@
"dependencies": [
"@stdlib/math/base/special/abs",
"@stdlib/math/base/special/round",
"@stdlib/math/base/special/pow",
"@stdlib/constants/float64/max-safe-integer",
"@stdlib/constants/float64/max-base10-exponent",
"@stdlib/constants/float64/min-base10-exponent",
"@stdlib/constants/float64/min-base10-exponent-subnormal",
"@stdlib/math/base/assert/is-infinite"
"@stdlib/math/base/assert/is-infinite",
"@stdlib/math/base/assert/is-nan"
]
}
]
Expand Down
9 changes: 5 additions & 4 deletions ...lib/math/base/special/roundn/src/roundn.c → ...tdlib/math/base/special/roundn/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@

#include "stdlib/math/base/special/roundn.h"
#include "stdlib/math/base/assert/is_infinite.h"
#include "stdlib/math/base/assert/is_nan.h"
#include "stdlib/math/base/special/abs.h"
#include "stdlib/math/base/special/round.h"
#include "stdlib/math/base/special/pow.h"
#include "stdlib/constants/float64/max_safe_integer.h"
#include "stdlib/constants/float64/max_base10_exponent.h"
#include "stdlib/constants/float64/min_base10_exponent.h"
#include "stdlib/constants/float64/min_base10_exponent_subnormal.h"
#include <stdint.h>
#include <math.h>

static const double MAX_INT = STDLIB_CONSTANT_FLOAT64_MAX_SAFE_INTEGER + 1.0;
static const double HUGE_VALUE = 1.0e+308;
Expand Down Expand Up @@ -115,7 +116,7 @@ double stdlib_base_roundn( const double x, const int32_t n ) {
double s;
double y;

if ( isnan( x ) ){
if ( stdlib_base_is_nan( x ) ){
return 0.0 / 0.0; // NaN
}

Expand All @@ -140,14 +141,14 @@ double stdlib_base_roundn( const double x, const int32_t n ) {
}
// If we overflow, return `x`, as the number of digits to the right of the decimal is too small (i.e., `x` is too large / lacks sufficient fractional precision) for there to be any effect when rounding...
if ( n < STDLIB_CONSTANT_FLOAT64_MIN_BASE10_EXPONENT ){
s = pow( 10.0, -( n + STDLIB_CONSTANT_FLOAT64_MAX_BASE10_EXPONENT ) ); // TODO: replace use of `pow` once have stdlib equivalent
s = stdlib_base_pow( 10.0, -( n + STDLIB_CONSTANT_FLOAT64_MAX_BASE10_EXPONENT ) );
y = ( x * HUGE_VALUE ) * s; // order of operation matters!
if ( stdlib_base_is_infinite( y ) ){
return x;
}
return ( stdlib_base_round( y ) / HUGE_VALUE ) / s;
}
s = pow( 10.0, -n ); // TODO: replace use of `pow` once have stdlib equivalent
s = stdlib_base_pow( 10.0, -n );
y = x * s;
if ( stdlib_base_is_infinite( y ) ){
return x;
Expand Down
Loading