-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for negative values in math/base/special/fmod
#2600
Conversation
This reverts commit a0c1fc4.
|
Signed-off-by: GUNJ JOSHI <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gunjjoshi!
Description
This pull request:
math/base/special/fmod
.Related Issues
None.
Questions
No.
Other
julia
, frommod
torem
. This is because,rem
handles negative values in a much better way.main.c
changed, yielding failures in tests. So, I kept it the same.Checklist
@stdlib-js/reviewers