Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tests for native implementation in math/base/special/ceilsd #2641

Merged
merged 1 commit into from
Jul 21, 2024
Merged

test: fix tests for native implementation in math/base/special/ceilsd #2641

merged 1 commit into from
Jul 21, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 21, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request:

  • addresses the changes to be made in 854b793

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 21, 2024
kgryte
kgryte approved these changes Jul 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte changed the title docs: cast to double, test with native implementation in math/base/special/ceilsd test: fix tests for native implementation in math/base/special/ceilsd Jul 21, 2024
@kgryte kgryte merged commit 6a0cbd9 into stdlib-js:develop Jul 21, 2024
6 checks passed
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
@gunjjoshi
test: fix tests for native implementation
28d7e8e 
PR-URL: stdlib-js#2641
Ref: stdlib-js#2631
Ref: stdlib-js@854b793
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gunjjoshi @kgryte @stdlib-bot