Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add C implementation for math/base/special/gamma-delta-ratio #2662

Merged
merged 11 commits into from
Aug 11, 2024

Conversation

gunjjoshi
Copy link
Member

@gunjjoshi gunjjoshi commented Jul 25, 2024

Description

What is the purpose of this pull request?

This pull request:

double stdlib_base_gamma_delta_ratio( const double z, const double delta );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Jul 25, 2024
@gunjjoshi
Copy link
Member Author

For packages like these, in order to compare the older and latest boost implementations, we'll have to go through the whole implementations ( which are quite large ). Is there any other way of comparing them, or we should check everything line by line?

@kgryte
Copy link
Member

kgryte commented Jul 25, 2024

@gunjjoshi 1) You should be consulting the Boost GitHub repo when examining implementations: https://github.com/boostorg/math/blob/develop/include/boost/math/special_functions/gamma.hpp. 2) Using the repo, you can perform a diff between the two Boost versions for the implementation in question. Based on commit history and diff, you can determine whether the implementation has changed. If it has changed, then you need to determine which lines have changed and whether we need to make any updates.

@kgryte
Copy link
Member

kgryte commented Jul 25, 2024

In short, use the tools available to you to simplify the R&D. 🙂

Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Copy link
Member Author

@kgryte I found the difference here, and it doesn't seem there is any change in the implementation for gamma-delta-ratio. So, I've updated the links in main.c and main.js.

@kgryte
Copy link
Member

kgryte commented Jul 26, 2024

@gunjjoshi instead of using the GitHub UI, in the future, I suggest cloning the Boost repo and doing the diff locally, that way you can do a diff on only the file in question.

@Planeshifter Planeshifter self-requested a review July 26, 2024 13:10
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Jul 28, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land this one! 🚀

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Aug 11, 2024
@Planeshifter Planeshifter merged commit 3985f47 into stdlib-js:develop Aug 11, 2024
16 checks passed
@gunjjoshi gunjjoshi deleted the gamma-delta-ratio branch August 11, 2024 10:01
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
PR-URL: stdlib-js#2662 
Ref: stdlib-js#649

---------

Signed-off-by: GUNJ JOSHI <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]> 
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants