feat!: add C implementation for math/base/special/truncsd
#2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
added
Ready To Merge
gunjjoshi
added a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
BREAKING CHANGE: The third argument 'b' in the JavaScript implementation of `truncsd` is now mandatory. To migrate, explicitly supply the old default value of `10` as the third argument. PR-URL: stdlib-js#2666 Ref: stdlib-js#649 Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
math/base/special/truncsd.javascriptimplementation to make the third argument,b, as mandatory.Related Issues
This pull request:
Questions
No.
Other
I have added a
!in the commit message to indicate that this PR has breaking changes.Checklist
@stdlib-js/reviewers