Skip to content

docs: compare n with integer, not a double in math/base/special/binomcoefln #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • addresses 5b184b6#r145257914
  • as n is an integer, it should be compared with 0 instead of 0.0.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Aug 11, 2024
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Aug 11, 2024
@Planeshifter Planeshifter merged commit 01126b1 into stdlib-js:develop Aug 11, 2024
19 checks passed
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this pull request Aug 21, 2024
…al/binomcoefln`

PR-URL: stdlib-js#2775 

Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants