refactor: use stdlib fmod
and DDD_D
napi function in math/base/special/wrap
#2814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
TODO
to removemath.h
in theC
implementation and usestdlib_base_fmod
inmath/base/special/wrap
.DDD_D
napi
function, instead of writing everything again inaddon.c
.fmod
injs
implementation as well, even though the%
operator injs
works fine, so that we do not have differences in our implementations.Related Issues
None.
Questions
No.
Other
While committing the changes, the
C
implementation was giving styling errors, indicating that on lines https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/wrap/src/main.c#L52, https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/wrap/src/main.c#L55 and https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/wrap/src/main.c#L58, the conditions were not proper, as we are checking if it is+-0
and assigning it as+0
again. To avoid this, I usedstdlib_base_abs
in the conditions. Though this error was only coming forC
implementation, I applied the changes to thejs
implementation as well, so that they are close enough.Checklist
@stdlib-js/reviewers