Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/maxf #2816

Merged
merged 395 commits into from
Aug 23, 2024
Merged

feat: add math/base/special/maxf #2816

merged 395 commits into from
Aug 23, 2024

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

float stdlib_base_maxf( const float x, const float y );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Aug 21, 2024
@gunjjoshi gunjjoshi marked this pull request as draft August 21, 2024 08:38
@gunjjoshi gunjjoshi marked this pull request as ready for review August 21, 2024 08:39
kgryte and others added 27 commits August 21, 2024 14:16
PR-URL: stdlib-js#2548
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Pranav Goswami <[email protected]>
PR-URL: stdlib-js#2578
Ref: stdlib-js#2464
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2690
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2691
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2689
Ref: stdlib-js#649 

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
…README.md`

PR-URL: stdlib-js#2677

Signed-off-by: GUNJ JOSHI <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2668
Ref: stdlib-js#2464
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2692
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2697
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2696
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
kgryte and others added 21 commits August 21, 2024 14:16
PR-URL: stdlib-js#2807
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2806
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: stdlib-bot <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2808

---------

Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2794
Ref: stdlib-js#2039
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@gunjjoshi gunjjoshi marked this pull request as draft August 21, 2024 08:49
@gunjjoshi gunjjoshi marked this pull request as ready for review August 21, 2024 09:27
@kgryte
Copy link
Member

kgryte commented Aug 23, 2024

@gunjjoshi You'll want to apply any relevant changes made in #2820 to this PR.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. Feature Issue or pull request for adding a new feature. labels Aug 23, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Aug 23, 2024
@kgryte kgryte merged commit 15878f9 into stdlib-js:develop Aug 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants