-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/maxf
#2816
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: stdlib-js#2548 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Pranav Goswami <[email protected]>
PR-URL: stdlib-js#2578 Ref: stdlib-js#2464 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2690 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2691 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2687 Ref: stdlib-js#649 Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2660 Ref: stdlib-js#649 Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2689 Ref: stdlib-js#649 --------- Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
…README.md` PR-URL: stdlib-js#2677 Signed-off-by: GUNJ JOSHI <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2668 Ref: stdlib-js#2464 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2692 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2697 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2696 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]>
…ributing guidelines build: update wording
PR-URL: stdlib-js#2699 Ref: stdlib-js@f5d15f7#r144735243 Ref: stdlib-js@f5d15f7#r144735169 Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2702 Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2701 Ref: stdlib-js@62e247d#commitcomment-144735358 Ref: stdlib-js@62e247d#r144735333 Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2700 Ref: stdlib-js@f2f6164#r144735363 Ref: stdlib-js@f2f6164#r144735366 Ref: stdlib-js@f2f6164#r144735371 Reviewed-by: Athan Reines <[email protected]>
PR-URL: stdlib-js#2807 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]>
PR-URL: stdlib-js#2806 Reviewed-by: Athan Reines <[email protected]> Signed-off-by: stdlib-bot <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2808 --------- Signed-off-by: Gunj Joshi <[email protected]> Signed-off-by: Philipp Burckhardt <[email protected]> Co-authored-by: Philipp Burckhardt <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
PR-URL: stdlib-js#2794 Ref: stdlib-js#2039 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]>
This reverts commit 71ff8ee.
This reverts commit b345bfe.
@gunjjoshi You'll want to apply any relevant changes made in #2820 to this PR. |
kgryte
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @gunjjoshi!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
math/base/special/maxf
, which would be the single-precision variant formath/base/special/max
.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers