-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix benchmark issue #5862 , Fix quantile comments #5869 #5909
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Hi @stdlib-bot , I hope you're doing well! I've created a pull request that updates comments in two files to improve clarity and documentation. All tests have passed, and code coverage remains at 100%. Whenever you get a chance, could you please review the pull request? Additionally, the workflows in the PR require manual approval, so I would appreciate it if you could take a look at those too. Here’s the link to the PR: PR-akash8843:fix-quantile-comments Thank you so much for your time and guidance! Please let me know if there’s anything else you’d like me to address. Best regards, Akash |
hello @stdlib-bot,,"I noticed that some workflows are awaiting approval. Could you please approve them so I can verify the checks? Thank you!" |
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Hello @stdlib-js/reviewers, Thank you! 🚀 |
Ref: #5873 |
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Resolves #5869, #5862
Description
What is the purpose of this pull request?
This pull request fixes comments related to the benchmark issue and quantile functionality for better code clarity and documentation.
Related Issues
Does this pull request have any related issues?
This pull request:
Resolves #5869
Resolves #5862
Acknowledgment
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request?
This may include screenshots, references, and/or implementation notes.
No.
@stdlib-js/reviewers