perf: optimize query array filtering in InMemoryStorage#278
Open
vincerevu wants to merge 6 commits intosteel-dev:mainfrom
Open
perf: optimize query array filtering in InMemoryStorage#278vincerevu wants to merge 6 commits intosteel-dev:mainfrom
vincerevu wants to merge 6 commits intosteel-dev:mainfrom
Conversation
Adds an `aria-label` to the icon-only console toggle button in `SessionContainer` so screen readers can identify the action. Also adds a `title` attribute to provide a tooltip for mouse users.
…query-9683142271173482330 perf: optimize query array filtering in in-memory-storage
…-10652984871791702189 fix(ui): add accessibility attributes to console toggle button
…1392684622017 fix: add timeout and cleanup to external file downloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Condense multiple sequential
.filter()passes inInMemoryStorage.queryinto a single pass.Why
The previous implementation:
[...this.events].filter()callsThis results in repeated iterations and unnecessary intermediate allocations.
Change
Impact
Verification
npm run build