change .gitattributes encoding UTF-16 to UTF-8 and set it for lang files #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For UTF-16, git converts back to UTF-16BE BOM, but MSVC silently takes it. MSVC compiler recognizes UTF-8 BOM. VS2022 stores UTF-8 rc file with `#pragma` instead of BOM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For UTF-16, git converts back to UTF-16BE BOM, but MSVC silently takes it without error.
MSVC compiler recognizes UTF-8 BOM.
VS2022 stores UTF-8 rc file with
#pragma code_page(65001)instead of BOM.My bad. I recalled the binaries was good, during several times hard reset.
Now, it has been tested by Build Tools with
clv19.33.31630 and VS2022 v17.8.6 withclv19.38.33135.