Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds HistoryArchiveUtils::readNextEntry<T> to read entries from an XD… #4641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThomasBrady
Copy link
Contributor

@ThomasBrady ThomasBrady commented Feb 5, 2025

Resolves ##4567

Description

Adds HistoryArchiveUtils::readNextEntry<T> to read entries from an XDRInputFileStream with ledgerSeq bounds checking. Uses readNextEntry to read TransactionHistoryEntry and TransactionHistoryResultEntry in ApplyCheckpointWork and VerifyTxResultsWork.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@ThomasBrady ThomasBrady force-pushed the result-tx-set-iteration-de-duplicate branch from a6bd71e to e3ecae2 Compare February 5, 2025 18:58
…RInputFileStream with ledgerSeq bounds checking
@ThomasBrady ThomasBrady force-pushed the result-tx-set-iteration-de-duplicate branch from e3ecae2 to 4733d4c Compare February 5, 2025 19:17
@ThomasBrady ThomasBrady requested a review from dmkozh February 5, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant