CPU/RISCV64: Fix gte_completion_tick store in EndAndLinkBlock#3702
Merged
stenzek merged 1 commit intostenzek:masterfrom Mar 3, 2026
Merged
CPU/RISCV64: Fix gte_completion_tick store in EndAndLinkBlock#3702stenzek merged 1 commit intostenzek:masterfrom
stenzek merged 1 commit intostenzek:masterfrom
Conversation
Store RARG2 (the computed value) instead of RARG1 to gte_completion_tick, matching the behavior of other architecture recompilers.
Owner
|
I think there's a second error here, it's overwriting the previously-loaded downcount which gets compared in the following instruction. Net result would be the event running on the next block without GTE instructions. I'll push that as a separate change since it affects everything not-x86 (probably an error that originated in arm64, which the others were derived from). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store RARG2 (the computed value) instead of RARG1 to gte_completion_tick, matching the behavior of other architecture recompilers.