Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the flag firstArrivingMeterValueIfMultiple and its usage #1423

Merged
merged 1 commit into from
Apr 2, 2024

remove the flag firstArrivingMeterValueIfMultiple and its usage (clos…

4125e75
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

remove the flag firstArrivingMeterValueIfMultiple and its usage #1423

remove the flag firstArrivingMeterValueIfMultiple and its usage (clos…
4125e75
Select commit
Loading
Failed to load commit list.
GitHub Actions / checkstyle succeeded Mar 26, 2024 in 0s

reviewdog [checkstyle] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (242)

src/main/java/de/rwth/idsg/steve/NotificationFeature.java|33| Line is longer than 120 characters (found 181).
src/main/java/de/rwth/idsg/steve/JettyServer.java|284| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/config/OcppConfiguration.java|70| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java|262| Line is longer than 120 characters (found 148).
src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java|264| Line is longer than 120 characters (found 169).
src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java|272| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java|22 col 8| Unused import - com.fasterxml.jackson.datatype.joda.JodaModule.
src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java|71| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java|158| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java|187 col 5| Class ApiKeyAuthenticationEntryPoint should be declared as final.
src/main/java/de/rwth/idsg/steve/SteveAppContext.java|82| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/SteveAppContext.java|121| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/NotificationService.java|65| Line is longer than 120 characters (found 171).
src/main/java/de/rwth/idsg/steve/service/NotificationService.java|101| Line is longer than 120 characters (found 148).
src/main/java/de/rwth/idsg/steve/service/NotificationService.java|113| Line is longer than 120 characters (found 226).
src/main/java/de/rwth/idsg/steve/service/NotificationService.java|124| Line is longer than 120 characters (found 175).
src/main/java/de/rwth/idsg/steve/service/ChargePointService12_Client.java|56 col 14| Name 'ChargePointService12_Client' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/service/ChargePointService12_Client.java|58 col 51| Variable 'executorService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/service/ChargePointService12_Client.java|59 col 36| Variable 'taskStore' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/service/OcppTagService.java|126| Line is longer than 120 characters (found 140).
src/main/java/de/rwth/idsg/steve/service/OcppTagService.java|180| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/service/OcppTagService.java|209| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/service/ChargePointService15_Client.java|55 col 14| Name 'ChargePointService15_Client' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/service/ChargePointService15_Client.java|57 col 41| Variable 'ocppTagService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/service/ChargePointService15_Client.java|58 col 48| Variable 'reservationRepository' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/service/ChargePointService16_Client.java|51 col 14| Name 'ChargePointService16_Client' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/service/ChargePointService16_Client.java|95| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/service/ChargePointService16_Client.java|128| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java|72 col 14| Name 'CentralSystemService16_Service' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java|93| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java|129 col 58| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/service/CentralSystemService16_Service.java|203 col 54| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|83| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|116| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|151| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|162| Line is longer than 120 characters (found 146).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|165| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|167| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|169| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|217| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|224| Line is longer than 120 characters (found 131).
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|229 col 13| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/service/ChargePointHelperService.java|230| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/ocpp/task/RemoteStartTransactionTask.java|57 col 7| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/task/SetChargingProfileTask.java|99| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/ocpp/task/SetChargingProfileTask.java|99 col 73| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/task/GetConfigurationTask.java|40| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/task/GetConfigurationTask.java|106 col 5| Class ResponseWrapper should be declared as final.
src/main/java/de/rwth/idsg/steve/ocpp/task/ClearChargingProfileTask.java|70| Line is longer than 120 characters (found 145).
src/main/java/de/rwth/idsg/steve/ocpp/task/GetCompositeScheduleTask.java|36| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_Invoker.java|31 col 18| Name 'ChargePointService16_Invoker' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/ocpp/OcppCallback.java|36| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|52 col 14| Name 'ChargePointService15_InvokerImpl' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|58| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|66| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|75| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|84| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|93| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|102| Line is longer than 120 characters (found 134).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|112| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|121| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|130| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|139| Line is longer than 120 characters (found 140).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|148| Line is longer than 120 characters (found 131).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|157| Line is longer than 120 characters (found 135).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|166| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|175| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|184| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_InvokerImpl.java|193| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/Ocpp15AndAboveTask.java|31| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|77| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|96| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|105| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|152| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|167| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Convert.java|27 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|295 col 47| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|296 col 45| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|297 col 49| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|298 col 51| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16Impl.java|299 col 41| Avoid inline conditionals.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|33| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|39| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|55| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|61| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|33| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|39| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|57| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|63| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/ocpp/CommunicationTask.java|55 col 23| Variable 'params' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ocpp12/Ocpp12WebSocketEndpoint.java|79| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/ws/data/CommunicationContext.java|65 col 11| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/data/CommunicationContext.java|71 col 11| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/MeterValue15Mixin.java|33 col 22| Variable 'values' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/CustomStringModule.java|60 col 9| Redundant 'public' modifier.
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/CustomStringModule.java|87| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/ws/PingTask.java|50 col 15| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|38 col 30| Name 'sendTimeLimit' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|39 col 30| Name 'bufferSizeLimit' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|64| Line is longer than 120 characters (found 144).
src/main/java/de/rwth/idsg/steve/ocpp/ws/ocpp16/Ocpp16WebSocketEndpoint.java|79| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java|39| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java|59| Line is longer than 120 characters (found 144).
src/main/java/de/rwth/idsg/steve/ocpp/ws/ocpp15/Ocpp15WebSocketEndpoint.java|79| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|21 col 8| Unused import - de.rwth.idsg.steve.config.WebSocketConfiguration.
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|66| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|111 col 86| ')' is preceded with whitespace.
src/main/java/de/rwth/idsg/steve/ocpp/ws/AbstractWebSocketEndpoint.java|77| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/ocpp/ws/AbstractWebSocketEndpoint.java|78| Line is longer than 120 characters (found 145).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|23 col 36| Using the '.' form of import should be avoided - de.rwth.idsg.steve.ocpp.task..
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|38 col 14| Name 'ChargePointService16_InvokerImpl' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|44| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|52| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|61| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|70| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|79| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|88| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|97| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|106| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|115| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|124| Line is longer than 120 characters (found 134).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|134| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|143| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|152| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|161| Line is longer than 120 characters (found 140).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|170| Line is longer than 120 characters (found 131).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|179| Line is longer than 120 characters (found 135).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|188| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|197| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|206| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService16_InvokerImpl.java|215| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/Ocpp16AndAboveTask.java|31| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService15_Invoker.java|33 col 18| Name 'ChargePointService15_Invoker' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_Invoker.java|36 col 18| Name 'ChargePointService12_Invoker' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|46 col 14| Name 'ChargePointService12_InvokerImpl' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|52| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|60| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|69| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|78| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|87| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|96| Line is longer than 120 characters (found 134).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|105| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|114| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|123| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/ocpp/ChargePointService12_InvokerImpl.java|132| Line is longer than 120 characters (found 140).
src/main/java/de/rwth/idsg/steve/ocpp/soap/CentralSystemService12_SoapServer.java|72 col 14| Name 'CentralSystemService12_SoapServer' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/ocpp/soap/CentralSystemService16_SoapServer.java|70 col 14| Name 'CentralSystemService16_SoapServer' must match pattern '^[A-Z][a-zA-Z0-9]
$'.
src/main/java/de/rwth/idsg/steve/ocpp/soap/CentralSystemService16_SoapServer.java|253| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/ocpp/soap/CentralSystemService15_SoapServer.java|73 col 14| Name 'CentralSystemService15_SoapServer' must match pattern '^[A-Z][a-zA-Z0-9]$'.
src/main/java/de/rwth/idsg/steve/web/dto/ChargingProfileForm.java|125 col 34| Name 'defaultNumberPhases' must match pattern '^[A-Z][A-Z0-9]
(_[A-Z0-9]+)*$'.
... (Too many findings. Dropped some findings)