refactor task/job executors #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* migrate from java's executor impl to spring's abstraction: let spring handle the bean lifecycle, graceful shutdown etc. * separate on interface-level between scheduled and async tasks: we only have 1 use case for scheduled tasks (websocket ping-pongs), whereas all other usages of ScheduledExecutorService were just async job submissions. separation might be useful in future, if we want to have distinct thread pools as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate from java's executor impl to spring's abstraction: let spring handle the bean lifecycle, graceful shutdown etc.
separate on interface-level between scheduled and async tasks: we only have 1 use case for scheduled tasks (websocket ping-pongs), whereas all other usages of ScheduledExecutorService were just async job submissions. separation might be useful in future, if we want to have distinct thread pools as well.
with regards to the previous point: separate TaskExecutor and TaskScheduler usage already