refactor task/job executors #2219
reviewdog [checkstyle] report
reported by reviewdog 🐶
Findings (1)
src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java|62 col 8| Unused import - java.util.concurrent.Executor.
Filtered Findings (249)
src/main/java/de/rwth/idsg/steve/Application.java|45| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/utils/PropertiesFileLoader.java|53 col 113| '+' should be on a new line.
src/main/java/de/rwth/idsg/steve/utils/PropertiesFileLoader.java|69 col 33| ',' is not followed by whitespace.
src/main/java/de/rwth/idsg/steve/utils/PropertiesFileLoader.java|73 col 33| ',' is not followed by whitespace.
src/main/java/de/rwth/idsg/steve/utils/ControllerHelper.java|23 col 8| Unused import - lombok.experimental.UtilityClass.
src/main/java/de/rwth/idsg/steve/utils/ControllerHelper.java|35 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/ConnectorStatusFilter.java|37 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/StringUtils.java|40 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/ConnectorStatusCountFilter.java|37 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/UserFormMapper.java|33 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/ChargingProfileDetailsMapper.java|42 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/ChargingProfileDetailsMapper.java|56| Line is longer than 120 characters (found 135).
src/main/java/de/rwth/idsg/steve/utils/mapper/AddressMapper.java|31 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/OcppTagFormMapper.java|32 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/mapper/ChargePointDetailsMapper.java|31 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/OcppTagActivityRecordUtils.java|26 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/CountryCodesProvider.java|36 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/TransactionStopServiceHelper.java|27 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/DateTimeUtils.java|37 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/InternetChecker.java|37 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/CustomDSL.java|39 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/utils/CustomDSL.java|43| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/config/OcppConfiguration.java|70| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java|49| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java|70| Line is longer than 120 characters (found 134).
src/main/java/de/rwth/idsg/steve/config/SecurityConfiguration.java|92| Line is longer than 120 characters (found 137).
src/main/java/de/rwth/idsg/steve/config/WebSocketConfiguration.java|36 col 8| Unused import - java.util.concurrent.TimeUnit.
src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java|223| Line is longer than 120 characters (found 148).
src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java|225| Line is longer than 120 characters (found 169).
src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java|233| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/JettyServer.java|276| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/web/api/ApiControllerAdvice.java|72| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/web/api/ApiControllerAdvice.java|88| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java|50| Line is longer than 120 characters (found 172).
src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java|67| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java|68| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/TransactionsRestController.java|69| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|77| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|78| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|79| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|96| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|97| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|98| Line is longer than 120 characters (found 183).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|99| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|117| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|118| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|119| Line is longer than 120 characters (found 194).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|120| Line is longer than 120 characters (found 183).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|121| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|141| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|142| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|143| Line is longer than 120 characters (found 183).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|144| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|148| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|165| Line is longer than 120 characters (found 185).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|166| Line is longer than 120 characters (found 186).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|167| Line is longer than 120 characters (found 183).
src/main/java/de/rwth/idsg/steve/web/api/OcppTagsRestController.java|168| Line is longer than 120 characters (found 195).
src/main/java/de/rwth/idsg/steve/web/validation/IdTag.java|39| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/web/controller/OcppTagsController.java|39 col 8| Unused import - java.util.List.
src/main/java/de/rwth/idsg/steve/web/controller/OcppTagsController.java|49 col 41| Variable 'ocppTagService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|55 col 48| Variable 'chargePointRepository' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|56 col 51| Variable 'chargePointHelperService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|60| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|60 col 39| Name 'upToOcpp15RegistrationStatusList' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|61| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|64| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|64 col 39| Name 'ocpp16RegistrationStatusList' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/web/controller/ChargePointsController.java|65| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/web/controller/Ocpp16Controller.java|88| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/web/controller/Ocpp12Controller.java|58 col 51| Variable 'chargePointHelperService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/Ocpp12Controller.java|59 col 41| Variable 'ocppTagService' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/controller/Ocpp12Controller.java|60 col 51| Variable 'chargePointServiceClient' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/web/dto/OcppTagQueryForm.java|57| Line is longer than 120 characters (found 171).
src/main/java/de/rwth/idsg/steve/web/dto/QueryForm.java|45| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/web/dto/QueryForm.java|48| Line is longer than 120 characters (found 143).
src/main/java/de/rwth/idsg/steve/web/dto/EndpointInfo.java|38| Line is longer than 120 characters (found 121).
src/main/java/de/rwth/idsg/steve/web/dto/EndpointInfo.java|39| Line is longer than 120 characters (found 151).
src/main/java/de/rwth/idsg/steve/web/dto/EndpointInfo.java|41 col 5| Class ItemsWithInfo should be declared as final.
src/main/java/de/rwth/idsg/steve/web/dto/TransactionQueryForm.java|49| Line is longer than 120 characters (found 170).
src/main/java/de/rwth/idsg/steve/web/dto/ChargingProfileForm.java|125 col 34| Name 'defaultNumberPhases' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/web/dto/ocpp/SendLocalListParams.java|52| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/web/dto/ocpp/ClearChargingProfileParams.java|45| Line is longer than 120 characters (found 130).
src/main/java/de/rwth/idsg/steve/web/LocalDateTimeEditor.java|28 col 8| Unused import - org.springframework.security.core.parameters.P.
src/main/java/de/rwth/idsg/steve/SteveAppContext.java|80| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/SteveAppContext.java|174| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/SteveAppContext.java|196| Line is longer than 120 characters (found 131).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|106| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|122| Line is longer than 120 characters (found 146).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|124| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|277| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|279| Line is longer than 120 characters (found 149).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|283| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|313| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargingProfileRepositoryImpl.java|359| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|169| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|307 col 23| Variable 'existsAlready' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/repository/impl/OcppServerRepositoryImpl.java|308 col 19| Variable 'transactionId' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|104| Line is longer than 120 characters (found 139).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|147| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|251| Line is longer than 120 characters (found 148).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|337| Line is longer than 120 characters (found 214).
src/main/java/de/rwth/idsg/steve/repository/impl/TransactionRepositoryImpl.java|339| Line is longer than 120 characters (found 167).
src/main/java/de/rwth/idsg/steve/repository/impl/UserRepositoryImpl.java|166| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|88| Line is longer than 120 characters (found 123).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|116| Line is longer than 120 characters (found 124).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|261| Line is longer than 120 characters (found 149).
src/main/java/de/rwth/idsg/steve/repository/impl/OcppTagRepositoryImpl.java|263| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/impl/GenericRepositoryImpl.java|76 col 90| '+' should be on a new line.
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|91| Line is longer than 120 characters (found 141).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|272| Line is longer than 120 characters (found 129).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|357| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/repository/impl/ChargePointRepositoryImpl.java|372| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/repository/impl/ReservationRepositoryImpl.java|163| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/repository/impl/ReservationRepositoryImpl.java|174 col 116| '+' should be on a new line.
src/main/java/de/rwth/idsg/steve/repository/ChargePointRepository.java|42| Line is longer than 120 characters (found 133).
src/main/java/de/rwth/idsg/steve/repository/dto/Transaction.java|37| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/repository/ReservationStatus.java|31| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/NotificationFeature.java|33| Line is longer than 120 characters (found 181).
src/main/java/de/rwth/idsg/steve/ocpp/CommunicationTask.java|54 col 23| Variable 'params' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Convert.java|27 col 1| Utility classes should not have a public or default constructor.
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|77| Line is longer than 120 characters (found 122).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|96| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|105| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|152| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15Impl.java|167| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|33| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|39| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|55| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server12to15.java|61| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|33| Line is longer than 120 characters (found 132).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|39| Line is longer than 120 characters (found 138).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|57| Line is longer than 120 characters (found 136).
src/main/java/de/rwth/idsg/steve/ocpp/converter/Server15to16.java|63| Line is longer than 120 characters (found 142).
src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java|39| Line is longer than 120 characters (found 127).
src/main/java/de/rwth/idsg/steve/ocpp/ws/WebSocketLogger.java|59| Line is longer than 120 characters (found 144).
src/main/java/de/rwth/idsg/steve/ocpp/ws/PingTask.java|50 col 15| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ocpp15/Ocpp15WebSocketEndpoint.java|79| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/CustomStringModule.java|60 col 9| Redundant 'public' modifier.
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/CustomStringModule.java|87| Line is longer than 120 characters (found 126).
src/main/java/de/rwth/idsg/steve/ocpp/ws/custom/MeterValue15Mixin.java|33 col 22| Variable 'values' must be private and have accessor methods.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|38 col 30| Name 'sendTimeLimit' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|39 col 30| Name 'bufferSizeLimit' must match pattern '^[A-Z][A-Z0-9](_[A-Z0-9]+)$'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ConcurrentWebSocketHandler.java|64| Line is longer than 120 characters (found 144).
src/main/java/de/rwth/idsg/steve/ocpp/ws/data/CommunicationContext.java|65 col 11| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/data/CommunicationContext.java|71 col 11| Comment matches to-do format 'TODO:'.
src/main/java/de/rwth/idsg/steve/ocpp/ws/ocpp12/Ocpp12WebSocketEndpoint.java|79| Line is longer than 120 characters (found 128).
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|21 col 8| Unused import - de.rwth.idsg.steve.config.WebSocketConfiguration.
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|69| Line is longer than 120 characters (found 125).
src/main/java/de/rwth/idsg/steve/ocpp/ws/OcppWebSocketHandshakeHandler.java|121 col 86| ')' is preceded with whitespace.
... (Too many findings. Dropped some findings)
Annotations
Check failure on line 62 in src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java
github-actions / checkstyle
[checkstyle] src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java#L62 <com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck>
Unused import - java.util.concurrent.Executor.
Raw output
/github/workspace/./src/main/java/de/rwth/idsg/steve/config/BeanConfiguration.java:62:8: error: Unused import - java.util.concurrent.Executor. (com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck)