Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: Set ingress paths as templated values #515

Closed
wants to merge 1 commit into from

Conversation

holmesb
Copy link

@holmesb holmesb commented Sep 21, 2022

Path part of URL is currently hard-coded to "/". In other words, can only configure the host part of URL.

Required creating a new env var "NEXUS_CONTEXT". This must omit the leading "/". This PR accepts ingress.path with leading "/", but strips it when adding NEXUS_CONTEXT.

Also required appending path to nexus_host var in configure.sh, otherwise pod gets stuck initialising when config.enabled.

@stevehipwell
Copy link
Owner

@holmesb are you requesting support for a path prefix? This chart intentionally doesn't support it due to the requirement to use subdomains for multi repo Docker support. Could you give me a use case where this would be valuable?

@holmesb
Copy link
Author

holmesb commented Sep 26, 2022

Yes. "multi repo Docker support" - pls can you expand, not sure what you mean. My fork works fine. Use case is where the host cannot be customised. In other words, this chart can be used when wildcard\subdomains\host records cannot be created.

@stevehipwell
Copy link
Owner

@holmesb have you tested this code with a multi Docker registry configuration using the chart? Docker registries using the port connector pattern, as supported by this chart, are made available at the root context on the port provided. I intentionally don't support adding a path prefix as this would make the documentation around the usage of the chart exponential more complex. I'm happy to discuss but I'm not understanding why you'd have a scenario where you're using K8s but can't easily generate subdomains (ExternalDNS) and corresponding certificates (Cert Manager)?

@holmesb
Copy link
Author

holmesb commented Oct 3, 2022

We already use Cert Manager. We could implement ExternalDNS, but customising paths is much simpler. This is the first chart I've come across that does not support this.

I'm still not really following you. Searching this chart for docker, registry and repo doesn't illuminate. There's only a single image.repository. If you could link to code it would help me understand and then test.

@stevehipwell
Copy link
Owner

@holmesb most charts "support" path because it's in the Helm template but that doesn't mean it actually works, and for complex software such as Nexus it often kind of works which is even worse.

If you use the chart in your PR to setup multiple docker registries using the config.repos value and matching service.additionalPorts value (you could just set the ports with service.additionalPorts and setup the registries in the UI) you can then test the behaviour for multiple Docker registries behind different ports.

@stale
Copy link

stale bot commented Nov 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 1, 2022
@stale stale bot closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants