Skip to content

refactor: simplify WDL module command and resolver internals - #1186

Open
claymcleod wants to merge 1 commit into
mainfrom
claymcleod-cleanup-wdl-modules
Open

refactor: simplify WDL module command and resolver internals#1186
claymcleod wants to merge 1 commit into
mainfrom
claymcleod-cleanup-wdl-modules

Conversation

@claymcleod

Copy link
Copy Markdown
Member

The module implementation retained unused cache helpers and Git re-exports, while the CLI commands repeated planning and persistence logic. Removed the obsolete resolver code, corrected cache documentation, and shared dependency validation and the add/remove relock-and-write sequence. Lock, update, and upgrade now prepare one plan before branching for dry runs, preserving signer checks, write ordering, and command output.

Added a regression test confirming that remove --no-lock skips resolution of a broken remaining dependency and preserves the existing lockfile byte-for-byte. Local validation passed 357 module library tests, four doctests, and 167 module command tests, plus workspace Clippy with warnings denied, nightly formatting, and spelling checks.

Workspace documentation also built with cargo --locked doc --workspace --no-deps; it reported three existing link warnings in unchanged files. This is an internal refactor; a changelog entry, website update, and lint-rule changes are N/A.

Before submitting this PR, please make sure:

For external contributors:

N/A — internal contribution.

  • You have read the contributing guide in its entirety.
  • You have not used AI on any parts of this pull request.
  • You have added a few sentences describing the PR here.
  • Your code builds clean without any errors or warnings.

For all contributors:

  • You have added tests (when appropriate).
  • You have added an entry in the CHANGELOG (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).
  • You have made a PR to the next branch in the sprocket.bio repository (when appropriate).

For PRs containing lint rule changes:

  • You have updated any and all effected entries within RULES.md.
  • You have added a test case in crates/wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.

@claymcleod
claymcleod requested a review from a team as a code owner September 8, 2026 16:40
@github-actions github-actions Bot added S-awaiting-pass-CI PR is awaiting CI to pass. and removed S-awaiting-pass-CI PR is awaiting CI to pass. labels Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant