refactor: simplify WDL module command and resolver internals - #1186
Open
claymcleod wants to merge 1 commit into
Open
refactor: simplify WDL module command and resolver internals#1186claymcleod wants to merge 1 commit into
claymcleod wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module implementation retained unused cache helpers and Git re-exports, while the CLI commands repeated planning and persistence logic. Removed the obsolete resolver code, corrected cache documentation, and shared dependency validation and the add/remove relock-and-write sequence. Lock, update, and upgrade now prepare one plan before branching for dry runs, preserving signer checks, write ordering, and command output.
Added a regression test confirming that
remove --no-lockskips resolution of a broken remaining dependency and preserves the existing lockfile byte-for-byte. Local validation passed 357 module library tests, four doctests, and 167 module command tests, plus workspace Clippy with warnings denied, nightly formatting, and spelling checks.Workspace documentation also built with
cargo --locked doc --workspace --no-deps; it reported three existing link warnings in unchanged files. This is an internal refactor; a changelog entry, website update, and lint-rule changes are N/A.Before submitting this PR, please make sure:
For external contributors:
N/A — internal contribution.
For all contributors:
nextbranch in the sprocket.bio repository (when appropriate).For PRs containing lint rule changes:
RULES.md.crates/wdl-lint/tests/lintsthat covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.