Support partitioning of hybrid boot disks #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@vojtechtrefny Does it make sense? Can we do this change globally or do you want to control it via a flag? |
This was referenced Nov 23, 2023
|
Jenkins, ok to test. |
vojtechtrefny
approved these changes
Nov 24, 2023
poncovka
force-pushed
the
3.9-devel-bootloader_devices_weight
branch
2 times, most recently
from
03a4deb to
63474c0
Compare
Anaconda needs to be able to create hybrid boot disks. For example: clearpart --all --initlabel --disklabel=gpt part prepboot --size=4 --fstype=prepboot part biosboot --size=1 --fstype=biosboot part /boot/efi --size=100 --fstype=efi part /boot --size=1000 --fstype=ext4 --label=boot part / --grow --fstype xfs However, this kickstart snippet is not working with two or more disks. The bootloader-related partitions should be all created on the disk the computer will boot from, but Blivet does that only for platform -specific partitions. The rest of them are created on any disk with enough space. It looks like this can be easily fixed by setting the same weight to all of these partitions regardless of the current platform. See: rhinstaller/anaconda#5298
poncovka
force-pushed
the
3.9-devel-bootloader_devices_weight
branch
from
63474c0 to
b39e390
Compare
|
Updated. |
vojtechtrefny
approved these changes
Nov 27, 2023
|
Just an update, Anaconda is not going to add the support for hybrid boot (at least for now, see rhinstaller/anaconda#5298 (comment)). I talked to @vojtechtrefny about this pull request and we think it's still a useful fix for anyone who wants to experiment with this feature in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anaconda needs to be able to create hybrid boot disks. For example:
However, this kickstart snippet is not working with two or more disks. The bootloader-related partitions should be all created on the disk the computer will boot from, but Blivet does that only for platform -specific partitions. The rest of them are created on any disk with enough space.
It looks like this can be easily fixed by setting the same weight to all of these partitions regardless of the current platform.
See: rhinstaller/anaconda#5298