all(ci): Fix failing integration tests #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GodTamIt
changed the title
Contributor
Author
|
@ifraixedes This looks to fix the integration tests now. The |
GodTamIt
changed the title
ifraixedes
previously approved these changes
May 29, 2025
ifraixedes
reviewed
May 29, 2025
Member
ifraixedes
left a comment
ifraixedes
left a comment
There was a problem hiding this comment.
@GodTamIt thank you very much
Could you update commit messages?
dd73f4f(#97) subject to be prefixed withall(deps):7aebe94(#97) to rename the previs toall(ci):
This adds the `--wait` and `--wait-timeout` options to the `docker compose up` so that containers are ready before running tests.
This includes version v1.2.8, which removes `versioncontrol`, which was causing CI failures.
Fix 2 linter issues that weren't caught by the previous Clippy version that we used.
Contributor
Author
|
@ifraixedes all done! I think this unblocks the chain of PRs you had for releasing the new version 🚀 |
Member
|
@GodTamIt I'll resolve the linter issues tomorrow because I don't think I will have time today. |
Contributor
Author
|
Ugh, this failure must be from a newer version of Rust. Hang on |
With the new version of Rust Clippy, these lints now suggest using `io::Error::other` for construction of `other` `io::Error` variants.
Contributor
Author
|
@ifraixedes all fixed |
ifraixedes
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
--waitand--wait-timeoutoptions to thedocker compose upso that containers are ready before running tests.This also bumps
storj/upto v1.2.10, which adds the fix toversioncheck(removes it), so that the integration test environment successfully loads up.Fixes #96