Re-adds Preact to homepage frameworks #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-addon-catalog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for storybook-frontpage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kylegach
reviewed
Feb 4, 2025
| @@ -40,6 +40,12 @@ export function HomeRenderers({ activeVersion }: HomeRenderersProps) { | |||
| title="React Native" | |||
| subtitle="on device" | |||
| /> | |||
| <Card | |||
There was a problem hiding this comment.
The original PR that added this placed it at the end of the card grid. Was it moved up on purpose?
I think it's more appropriately placed at the end.
There was a problem hiding this comment.
I left as such to be "React-adjacent". Technically, Preact is quite similar to React. Nothing more
kylegach
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #257 & #263
With this small pull request Preact is added to the list of supported frameworks.
What was done:
HomeRenderercomponent@kylegach when you're able, can you take a look into this pr and follow up with any feedback you may have? Thanks in advance